Design update for extract examples #42399
Conversation
romeovs
added
no-backport
|
Codenotify: Notifying subscribers in CODENOTIFY files for diff e23e654...479dba7.
|
|
romeovs
force-pushed
the
42375-design-update-for-extract-examples
branch
from
2d53129
to
1f04efc
Compare
| width: 100%; | ||
| } | ||
|
|
||
| .label { |
There was a problem hiding this comment.
This is one of the cases I discussed in the FE guild.
I need the button content to render as flex in this one usecase, do I need to override all Buttons everywhere on the site for that?
There was a problem hiding this comment.
Is this the same as https://metaboat.slack.com/archives/C057WD5L0JG/p1715204376544389?
There was a problem hiding this comment.
It's a similar issue than in that thread, but not the same exact component.
ClickActionControl is using some deprecated components and we're adding new designs and features to it.
There was a problem hiding this comment.
But you're overrides styles for a button in metabase/ui, which is new
There was a problem hiding this comment.
True, I meant more that this seems like a very one of usecase for the button.
I'm happy to make it a custom button, so there are no overrides, but I feel like that's not the way to go either.
The only reason I switched to ui/Button was because the legacy button that was used could not be customized properly (without having a large blast radius).
But I understand the comment to be about making sure we streamline the design process into forcing a more principled approach.
I'm not sure what the next steps here should be: push back to the design team? Use a fully custom component instead of using overrides?
There was a problem hiding this comment.
Could you ask @kdoh in ui proj channel?
Closes #42375
Description
Render the examples for Extract Column inline instead of underneath the title.
How to verify
Describe the steps to verify that the changes are working as expected.
Extract columnDemo
Notes
I updated the horizontal
ClickActionsControlto useButtonfrommetabase/uifor this, instead of the deprecatedButton. I can convert the rest to use CSS modules too if that is preferred.