Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prettier setup #196

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

prettier setup #196

wants to merge 11 commits into from

Conversation

lakshz
Copy link
Contributor

@lakshz lakshz commented May 4, 2024

Notes for Reviewers

This PR fixes #195

The prettier config is taken from meshery/meshery, and all the files formatting are changed based on that

Signed commits

  • Yes, I signed my commits.

@netlify Netlify
Copy link

netlify bot commented May 4, 2024 •
edited

✅ Deploy Preview for meshery-play ready!

Name Link
🔨 Latest commit e953f36
🔍 Latest deploy log https://app.netlify.com/sites/meshery-play/deploys/6638cdd1fc74bc00082b64ee
😎 Deploy Preview https://deploy-preview-196--meshery-play.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

lakshz and others added 9 commits May 4, 2024 10:34
@lakshz
set up prettier in /site
4a547ef 
Signed-off-by: lakshya <[email protected]>
@codeKraken19 @lakshz
[UI] clear whitespace
93d5ac9 
Signed-off-by: codeKraken <[email protected]>
@codeKraken19 @lakshz
[UI] remove dead code
a7e6091 
Signed-off-by: codeKraken <[email protected]>
@codeKraken19 @lakshz
[UI] add shared components
b87cbe8 
Signed-off-by: codeKraken <[email protected]>
@codeKraken19 @lakshz
[UI] add callout component
3fda547 
Signed-off-by: codeKraken <[email protected]>
@codeKraken19 @lakshz
[UI] remove dead code
a3be2d2 
Signed-off-by: codeKraken <[email protected]>
@codeKraken19 @lakshz
[UI] clean code
ddcb113 
Signed-off-by: codeKraken <[email protected]>
@codeKraken19 @lakshz
add proper error log
fd2ecbc 
Signed-off-by: codeKraken <[email protected]>
@codeKraken19 @lakshz
remove dead code
bd4d2fb 
Signed-off-by: codeKraken <[email protected]>
@lakshz lakshz changed the title Prettier setup Markdown Support in FAQs and prettier setup May 4, 2024
@lakshz lakshz requested a review from captain-Akshay May 4, 2024 11:55
vishalvivekm
vishalvivekm requested changes May 5, 2024
View reviewed changes
Copy link
Member

@vishalvivekm vishalvivekm left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conflicts...

#190 merged.

@lakshz lakshz changed the title Markdown Support in FAQs and prettier setup prettier setup May 5, 2024
@lakshz lakshz requested a review from vishalvivekm May 6, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@captain-Akshay captain-Akshay Awaiting requested review from captain-Akshay

@vishalvivekm vishalvivekm Awaiting requested review from vishalvivekm

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
area/website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prettier setup
3 participants
@lakshz @vishalvivekm @codeKraken19