Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add error code monikers #10958

Closed
wants to merge 2 commits into from

Conversation

EleisonC
Copy link
Contributor

@EleisonC EleisonC commented May 14, 2024

Notes for Reviewers
Add Error code monikers for Meshery server

This PR fixes #10761

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Christopher Kalule <[email protected]>
Copy link

github-actions bot commented May 14, 2024

@leecalcote leecalcote requested a review from lekaf974 May 14, 2024 21:03
Copy link
Member

@leecalcote leecalcote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Are these updates done after having changed the error code utility in MeshKit?

If you haven't seen the Messaging Framework and Notification Center design specification, it's a good one to peruse.

@leecalcote leecalcote requested a review from MUzairS15 May 14, 2024 21:06
@EleisonC
Copy link
Contributor Author

Thanks! Are these updates done after having changed the error code utility in MeshKit?

If you haven't seen the Messaging Framework and Notification Center design specification, it's a good one to peruse.

Alright I am taking a look

@leecalcote
Copy link
Member

I updated the Meshery Docs Error Codes page with (hopefully) helpful details with regard to the combination of details - https://docs.meshery.io/reference/error-codes

@leecalcote
Copy link
Member

@MUzairS15, as we go to enhance the format of the MeshKit Error Codes, will this format mess up anything other than the Meshery Docs error code page? Are Meshery Events v2 completely separate or do they use the same messaging framework, but with simply a different event format?

@aabidsofi19, the Notification Center will need to be updated, I assume.

@EleisonC
Copy link
Contributor Author

I updated the Meshery Docs Error Codes page with (hopefully) helpful details with regard to the combination of details - https://docs.meshery.io/reference/error-codes

Alright I will make the changes shortly and push them thank you for the help @leecalcote

Signed-off-by: Christopher Kalule <[email protected]>
@vishalvivekm
Copy link
Member

Hey @EleisonC , let's discuss this on today's Meshery Dev meeting at 7:30 PM IST. I am adding this as an agenda item. Please Join https://meet.layer5.io/meshery if you are available during the meet.

@leecalcote
Copy link
Member

Given the discussion on yesterday's meeting, are we closing this PR?

@leecalcote
Copy link
Member

Let me know if this is to be reopened...

@leecalcote leecalcote closed this May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Server] Not returning error code moniker in events, only numeric error code.
3 participants