[CI] Failing Unit test at System package level #10860

singh1203 · 2024-05-03T12:00:51Z

Notes for Reviewers

This PR fixes #10758

Signed commits

Yes, I signed my commits.

Signed-off-by: Saurabh Kumar Singh <[email protected]>

github-actions · 2024-05-03T12:03:00Z

codecov · 2024-05-03T12:06:25Z

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 9.33%. Comparing base (6179514) to head (1db8c3d).
Report is 3561 commits behind head on master.

❗ Current head 1db8c3d differs from pull request most recent head 8ac58ef

Please upload reports for the commit 8ac58ef to get more accurate results.

Files	Patch %	Lines
mesheryctl/internal/cli/root/system/provider.go	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #10860      +/-   ##
==========================================
- Coverage   10.13%    9.33%   -0.80%     
==========================================
  Files         140      146       +6     
  Lines       22170    19216    -2954     
==========================================
- Hits         2246     1794     -452     
+ Misses      19569    17091    -2478     
+ Partials      355      331      -24

Flag	Coverage Δ
unittests	`9.33% <33.33%> (-0.80%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mesheryctl/internal/cli/root/system/provider.go

mesheryctl/internal/cli/root/system/testdata/model/list.model.output.golden

mesheryctl/internal/cli/root/system/model.go

Signed-off-by: Saurabh Kumar Singh <[email protected]>

alphaX86

Changes look good. Here are my queries I have...

mesheryctl/internal/cli/root/system/model.go

mesheryctl/internal/cli/root/system/model_test.go

Signed-off-by: Saurabh Kumar Singh <[email protected]>

singh1203 · 2024-05-09T18:24:02Z

Changes look good. Here are my queries I have...

Please feel free to counter or point me in the right direction.
Thank you.

MUzairS15

model has been elevated to its own standalone command. @singh1203
// @alphaX86 @RipulHandoo Correct?

alphaX86 · 2024-05-10T15:30:40Z

model has been elevated to its own standalone command. @singh1203
// @alphaX86 @RipulHandoo Correct?

It should be. But it's still present within system :/ so it'd become a complete refactor in this case

mesheryctl/internal/cli/root/system/model.go

singh1203 · 2024-05-10T18:56:30Z

@alphaX86 Since it conflicts with the proper work that needs to be done, I believe that this PR is not necessary until this PR is merged #10602.
cc - @MUzairS15 @RipulHandoo

alphaX86 · 2024-05-11T15:45:54Z

@alphaX86 Since it conflicts with the proper work that needs to be done, I believe that this PR is not necessary until this PR is merged #10602. cc - @MUzairS15 @RipulHandoo

Seems that PR is auto-closed by the bot due to inactivity... // cc: @RipulHandoo

Signed-off-by: Saurabh Kumar Singh <[email protected]>

singh1203 · 2024-05-13T09:28:01Z

@alphaX86 Since it conflicts with the proper work that needs to be done, I believe that this PR is not necessary until this PR is merged #10602. cc - @MUzairS15 @RipulHandoo

Seems that PR is auto-closed by the bot due to inactivity... // cc: @RipulHandoo

Since PR #10602 is closed, I have removed conflicting changes and kept the ModelCmd as an exp command as previously for this PR continuity.

singh1203 · 2024-05-18T06:17:04Z

mesheryctl/internal/cli/root/system/provider.go

 if len(args) == 0 {
 return errors.New(utils.SystemProviderSubError("please specify a flag or subcommand. Use 'mesheryctl system provider --help' to display user guide.\n", "provider"))
 }
+ return nil
+ },
+ RunE: func(cmd *cobra.Command, args []string) error {


@leecalcote Here it is on L391

Jougan-0 · 2024-05-22T13:17:09Z

https://github.com/meshery/meshery/actions/runs/9137840475/job/25128309956?pr=10860
why failing merge recent branch and check i think my pr fixed it the mock server is not still running that is causing the issue and lee told to remove to remove the model_test.go completely here take a look

singh1203 · 2024-05-22T13:56:15Z

https://github.com/meshery/meshery/actions/runs/9137840475/job/25128309956?pr=10860
why failing merge recent branch and check i think my pr fixed it the mock server is not still running that is causing the issue and lee told to remove to remove the model_test.go completely here take a look

Due to some reason, will take a look after some time, resulting in an uneven 3-4 day time. Thank you!

singh1203 · 2024-05-22T17:16:22Z

Looks like your magic is working on this Parent PR #10703.
Thank you! @Jougan-0

https://github.com/meshery/meshery/actions/runs/9137840475/job/25128309956?pr=10860 why failing merge recent branch and check i think my pr fixed it the mock server is not still running that is causing the issue and lee told to remove to remove the model_test.go completely here take a look

singh1203 · 2024-05-22T17:19:01Z

Closing! It has already been resolved by #11002
// @leecalcote

singh1203 added 2 commits May 2, 2024 20:37

Uncommented with model and dry run

3b08032

Signed-off-by: Saurabh Kumar Singh <[email protected]>

fixed unit test for system package

f57ad39

Signed-off-by: Saurabh Kumar Singh <[email protected]>

github-actions bot added the component/mesheryctl CLI for Meshery label May 3, 2024

Merge branch 'master' into mesheryctl/test

cf15443

singh1203 marked this pull request as ready for review May 3, 2024 12:23

singh1203 changed the title ~~[WIP] Failing Unit test at System package level #10851~~ [CI] Failing Unit test at System package level #10851 May 3, 2024

singh1203 changed the title ~~[CI] Failing Unit test at System package level #10851~~ [CI] Failing Unit test at System package level May 3, 2024

leecalcote reviewed May 4, 2024

View reviewed changes

mesheryctl/internal/cli/root/system/provider.go Show resolved Hide resolved

leecalcote reviewed May 4, 2024

View reviewed changes

mesheryctl/internal/cli/root/system/testdata/model/list.model.output.golden Outdated Show resolved Hide resolved

leecalcote requested a review from lekaf974 May 4, 2024 03:41

Merge branch 'master' into mesheryctl/test

6e8504d

lekaf974 reviewed May 7, 2024

View reviewed changes

mesheryctl/internal/cli/root/system/model.go Outdated Show resolved Hide resolved

singh1203 added 2 commits May 7, 2024 10:35

Merge branch 'meshery:master' into mesheryctl/test

a09d227

Refactor: Remove unused code and update golden files for tests

5b1692b

Signed-off-by: Saurabh Kumar Singh <[email protected]>

singh1203 requested a review from lekaf974 May 7, 2024 05:26

Merge branch 'master' into mesheryctl/test

f3035a5

lekaf974 approved these changes May 8, 2024

View reviewed changes

leecalcote requested review from alphaX86 and RipulHandoo May 8, 2024 03:48

alphaX86 reviewed May 9, 2024

View reviewed changes

mesheryctl/internal/cli/root/system/model.go Outdated Show resolved Hide resolved

mesheryctl/internal/cli/root/system/model_test.go Outdated Show resolved Hide resolved

Refactor: Refactor the model.go & model_test.go files

50ca623

Signed-off-by: Saurabh Kumar Singh <[email protected]>

Merge branch 'master' into mesheryctl/test

5d3bb21

MUzairS15 reviewed May 10, 2024

View reviewed changes

RipulHandoo reviewed May 10, 2024

View reviewed changes

mesheryctl/internal/cli/root/system/model.go Outdated Show resolved Hide resolved

singh1203 added 3 commits May 13, 2024 14:25

fix: Resolved model.go conflict, preserved modelCmd

1c76a92

Signed-off-by: Saurabh Kumar Singh <[email protected]>

Merge branch 'master' into mesheryctl/test

cd7f62e

add: update golden file for reset command

1db8c3d

Signed-off-by: Saurabh Kumar Singh <[email protected]>

singh1203 requested review from alphaX86, MUzairS15 and leecalcote May 13, 2024 09:30

Merge branch 'meshery:master' into mesheryctl/test

8ac58ef

singh1203 commented May 18, 2024

View reviewed changes

leecalcote requested review from Jougan-0 and removed request for leecalcote and MUzairS15 May 21, 2024 21:54

singh1203 closed this May 22, 2024

singh1203 deleted the mesheryctl/test branch May 22, 2024 17:20

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[CI] Failing Unit test at System package level #10860

[CI] Failing Unit test at System package level #10860

singh1203 commented May 3, 2024 •

edited

github-actions bot commented May 3, 2024 •

edited

codecov bot commented May 3, 2024 •

edited

alphaX86 left a comment

singh1203 commented May 9, 2024 •

edited

MUzairS15 left a comment

alphaX86 commented May 10, 2024

singh1203 commented May 10, 2024

alphaX86 commented May 11, 2024

singh1203 commented May 13, 2024

singh1203 May 18, 2024

Jougan-0 commented May 22, 2024

singh1203 commented May 22, 2024

singh1203 commented May 22, 2024

singh1203 commented May 22, 2024

[CI] Failing Unit test at System package level #10860

[CI] Failing Unit test at System package level #10860

Conversation

singh1203 commented May 3, 2024 • edited

github-actions bot commented May 3, 2024 • edited

codecov bot commented May 3, 2024 • edited

Codecov Report

alphaX86 left a comment

Choose a reason for hiding this comment

singh1203 commented May 9, 2024 • edited

MUzairS15 left a comment

Choose a reason for hiding this comment

alphaX86 commented May 10, 2024

singh1203 commented May 10, 2024

alphaX86 commented May 11, 2024

singh1203 commented May 13, 2024

singh1203 May 18, 2024

Choose a reason for hiding this comment

Jougan-0 commented May 22, 2024

singh1203 commented May 22, 2024

singh1203 commented May 22, 2024

singh1203 commented May 22, 2024

singh1203 commented May 3, 2024 •

edited

github-actions bot commented May 3, 2024 •

edited

codecov bot commented May 3, 2024 •

edited

singh1203 commented May 9, 2024 •

edited