Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved Readme file #10855

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Conversation

praduman8435
Copy link

@praduman8435 praduman8435 commented May 2, 2024

Notes for Reviewers

This PR fixes #10770

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented May 2, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, you can find updates in the #github-notifications channel in the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while performing a commit.

Copy link

github-actions bot commented May 2, 2024

@Yashsharma1911 Yashsharma1911 added the area/docs Documentation update needed label May 3, 2024
@github-actions github-actions bot removed the area/docs Documentation update needed label May 3, 2024
README.md Show resolved Hide resolved
Signed-off-by: Praduman Prajapati <[email protected]>
Signed-off-by: Praduman Prajapati <[email protected]>
Signed-off-by: Praduman Prajapati <[email protected]>
@github-actions github-actions bot added the area/ci Continuous Integration label May 5, 2024
@praduman8435
Copy link
Author

@Yashsharma1911 , I have updated the PR

Copy link
Contributor

@ShivamCoder23 ShivamCoder23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@praduman8435 conflicts

Signed-off-by: Praduman Prajapati <[email protected]>
Signed-off-by: Praduman Prajapati <[email protected]>
@praduman8435
Copy link
Author

@praduman8435 conflicts

resolved conflicts

Signed-off-by: Praduman Prajapati <[email protected]>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this video from being directly embedded.

@leecalcote
Copy link
Member

@Yashsharma1911, let's find @praduman8435 another issue to work on. The issue that this PR links to is not a "good first issue" for the uninitiated to the Meshery project. We're just spinning our wheels here. A maintainer will need to pick this up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Continuous Integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Update Meshery repo README
4 participants