Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Service Mesh Icon with Pattern's icon #1746

Closed
wants to merge 1 commit into from

Conversation

Muhu-Muza
Copy link

Description

This PR fixes #1744
Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Copy link

welcome bot commented May 17, 2024

Yay, your first pull request! 👍 A contributor will be by to give feedback soon. In the meantime, please review the Newcomers' Guide and sure to join the community Slack.
Be sure to double-check that you have signed your commits. Here are instructions for making signing an implicit activity while peforming a commit.

Copy link

netlify bot commented May 17, 2024

Deploy Preview for mesheryio-preview ready!

Name Link
🔨 Latest commit 1cf8191
🔍 Latest deploy log https://app.netlify.com/sites/mesheryio-preview/deploys/6647ac6591a3380008c34588
😎 Deploy Preview https://deploy-preview-1746--mesheryio-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@vishalvivekm vishalvivekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Muhu-Muza What are these changes for ? can you please explain?
We just need to update the svg icon.

@vishalvivekm
Copy link
Member

vishalvivekm commented May 18, 2024

More over the service mesh Icon is still not updated with Pattern's icon ( mentioned in the issue )

Deploy Preview: https://deploy-preview-1746--mesheryio-preview.netlify.app/catalog

imageedit_4_3442016016

@vishalvivekm
Copy link
Member

@Muhu-Muza Let's discuss this on Websites's call on Monday. I've added this as an agenda item into the meeting minutes.

@leecalcote
Copy link
Member

Thanks, @Muhu-Muza!

@iArchitSharma, when you have a moment, will you offer feedback / review?

@Muhu-Muza
Copy link
Author

@vishalvivekm , I only updated the service mesh Icon with the pattern's icon.
I used the patterns svg that you provided earlier.
pattern

@vishalvivekm vishalvivekm mentioned this pull request May 21, 2024
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update SM Icon with Pattern's
3 participants