Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add error highlight #1300

Merged
merged 2 commits into from
Jun 17, 2024
Merged

feat: Add error highlight #1300

merged 2 commits into from
Jun 17, 2024

Conversation

sidharthv96
Copy link
Member

@sidharthv96 sidharthv96 commented Sep 15, 2023

📑 Summary

Adds syntax error highlighting with support for directives and yaml frontmatter.

📏 Design Decisions

Adapted from work by @pbrolin47 and @knsv at MermaidChart.
image

📋 Tasks

Make sure you

  • 📖 have read the contribution guidelines
  • 💻 have added unit/e2e tests (if appropriate)
  • 🔖 targeted develop branch

@netlify
Copy link

netlify bot commented Sep 15, 2023

Deploy Preview for mermaidjs ready!

Name Link
🔨 Latest commit aca7f07
🔍 Latest deploy log https://app.netlify.com/sites/mermaidjs/deploys/666fbe2f3c5e9b0008bc6edc
😎 Deploy Preview https://deploy-preview-1300--mermaidjs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@cypress
Copy link

cypress bot commented Sep 15, 2023

Passing run #1489 ↗︎

0 29 6 0 Flakiness 0

Details:

Merge aca7f07 into 368e741...
Project: Mermaid Live Editor Commit: 5139126d2f ℹ️
Status: Passed Duration: 01:54 💡
Started: Jun 17, 2024 4:41 AM Ended: Jun 17, 2024 4:43 AM

Review all test suite changes for PR #1300 ↗︎

Copy link

This pr is stale because it has been open 90 days with no activity. Remove stale label or comment or this will be closed in 30 days

@github-actions github-actions bot added the Stale label Dec 21, 2023
* develop: (148 commits)
  Remove error lines from View
  chore(deps): update all non-major dependencies
  chore(deps): update all non-major dependencies
  Remove stalebot
  build: update Browserslist db
  build: update Browserslist db
  chore: Add isRough to stats
  Update snapshots
  feat: Add rough mode
  fix(deps): update dependency mermaid to v10.9.1
  chore(deps): update all non-major dependencies
  build: update Browserslist db
  chore(deps): update dependency svelte to v4.2.16
  chore(deps): update all non-major dependencies
  chore(deps): update all non-major dependencies
  chore(deps): update all non-major dependencies
  build: update Browserslist db
  build: update Browserslist db
  chore(deps): update all non-major dependencies
  chore(deps): update all non-major dependencies
  ...
@sidharthv96 sidharthv96 added this pull request to the merge queue Jun 17, 2024
Merged via the queue into develop with commit 6d67f0c Jun 17, 2024
11 checks passed
@sidharthv96 sidharthv96 deleted the sidv/errorHighlight branch June 17, 2024 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant