Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transparently redirect direct mobile tx visits to pizza tracker #5010

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

mononaut
Copy link
Contributor

@mononaut mononaut commented Apr 22, 2024

This PR moves the new "Pizza Tracker" page under the same /tx/:txid route path as the main transaction page, and adds a canMatch route guard to selectively render the pizza tracker component if all of the following conditions are met:

  • Initial page load (i.e. not an internal navigation)
  • On mobile (window.innerWidth <= 767.98)
  • NOT overridden by query parameter ?mode=details

If the mode=details query parameter is set in the URL, then the full transaction page will always be displayed, so this can be used to explicitly link to the main page instead of the pizza tracker.

Leaving in draft for now because the tracker page needs some more polish before we funnel all of our /tx/ traffic there.

@mononaut mononaut requested review from wiz and softsimon April 22, 2024 15:49
@cla-bot cla-bot bot added the cla-signed label Apr 22, 2024
@mononaut mononaut force-pushed the mononaut/tracker-tx-routing branch from 1a323cf to c2a1426 Compare April 29, 2024 22:53
@mononaut
Copy link
Contributor Author

mononaut commented Jun 4, 2024

rebased on master, and taking out of draft (pending PR #5137)

@mononaut mononaut marked this pull request as ready for review June 4, 2024 23:07
@mempool mempool deleted a comment from Zoiediez Jun 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants