Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix viewPropsTypes #964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pallavi000
Copy link

Platforms affected

What does this PR do?

What testing has been done on this change?

Tested features checklist

@alissonbovenzo
Copy link

alissonbovenzo commented Dec 9, 2022

this source fixed my problem too

@Kaito-Dogi
Copy link

Kaito-Dogi commented Apr 18, 2023

Thank you for everything!
react-native-snap-carousel has delivered the best experience to our users.
We are experiencing the same error with our app and would love to have this pull request merged.
When will the version including this pull request be available?

Copy link

@Hitoshi082508 Hitoshi082508 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Exilz
Copy link
Contributor

Exilz commented Jun 16, 2023

Hi,
I’d be glad to merge a simple PR that fixes the ViewPropTypes (and only those). However, the PR you linked changed the whole code and the way it’s formatted. Because of that, I cannot review it with a quick glance.
Would you be able to open a PR that fixes only that? With as little code change as possible.

If you could do that and send me the PR, we could get this to master ASAP.

@gokuls99
Copy link

@hishamhadraoui @santisilva @jonatan-blossom
Hi Guys,
Someone please initiate to merge and make it available in npm. It will be really useful for us.

@rodrigoperaltarabbit
Copy link

@Exilz please, now you can merge this. for the community !

@FR073N
Copy link

FR073N commented Sep 1, 2023

Could you please tell us what is missing for you to merge it ? react-native-snap-carousel is one of the best plugin, and we should keep it alive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet