Remove redundant tests #345
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellnix
commented
Feb 29, 2024
| create_table :mongo_documents do |t| | ||
| t.string :name | ||
| end | ||
| end | ||
|
|
||
| class NullableId < ActiveRecord::Base |
There was a problem hiding this comment.
I could not find any place where this class was being used. Let me know if I should restore it or try to create new tests with records that return nil on their primary_key option.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #345 +/- ##
=======================================
Coverage 90.22% 90.22%
=======================================
Files 13 13
Lines 757 757
=======================================
Hits 683 683
Misses 74 74 ☔ View full report in Codecov by Sentry. |
ellnix
added
skip-changelog
This test seems to just use Marshal.dump on an object and then Marshal.load it later, which would pass for any ruby object.
This test seems to test that an object that is cached can be fetched
back from the cache. As proof, the meilisearch method calls can be
removed and the test passes just fine:
```ruby
context 'with Rails caching' do
let(:memory_store) { ActiveSupport::Cache.lookup_store(:memory_store) }
let(:search_query) { '*' }
let(:cache_key) { "book_search:#{search_query}" }
before do
allow(Rails).to receive(:cache).and_return(memory_store)
Rails.cache.clear
end
fit 'caches the search results' do
# Ensure the cache is empty before the test
expect(Rails.cache.read(cache_key)).to be_nil
# Perform the search and cache the results
Rails.cache.fetch(cache_key) do
search_query
end
# Check if the search result is cached
expect(Rails.cache.read(cache_key)).to eq(search_query)
end
end
```
It does not seem like Mongoid::Document has bang methods, so this is spec is not reproducing a likely naming conflict. In either case, the plan is to test with real MongoDB models so this test would be removed eventually.
ellnix
force-pushed
the
remove-redundant-tests
branch
from
81a5741
to
355250e
Compare
|
Rebased to |
'is_synchronous' tests a private method and only tests that the configuration was applied 'has maxValuesPerFacet set' tests meilisearch-ruby's Index class
|
Closing in favor of only keeping #350, this PR didn't pan out like I expected and thus is not useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continues after #342: Please only look at commits after "Remove redundant Ebook model"More changes toward resolving #332
Please see commit messages for more information on why each test was removed.