AudioBridge: (re) configure remote rtp #3380
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to address the topic discussed in https://janus.discourse.group/t/audiobridge-rtp-join-sip-scenarios/1049/3
This PR enhance slightly SIP interoperability provided by the plain RTP join feature of AudioBridge, such as in the case of an 18x message with SDP. Specifically, during an outbound SIP call, there is currently no way to direct RTP issued from a SIP 18x Ringing or Session Progress (e.g., ringback tone provided by RTP or a custom message sent by the operator during ringing), into the AudioBridge room.
Solution Proposal:
rtp
object in theconfigure
apijoin
requestjoin
request, then reconnect/rebind the same local RTP port with the the new remote RTP provided byconfigure
request.rtp
object inconfigure
request only if the participant has previously joined with plain rtp.configure
requestI believe this approach is backward compatible.
How this enhancement improve SIP interoperability? How will SIP/janus flow will be?
configure
request to janus with 18x SDP. Thus Audio room participants will hear rinback tone or ring message into roomconfigure
request to janus with SIP OK SDP or (2) make a RE-Invite without SDP and rejoin to janus ....Implementation & Tests
We have well tested with real word use cases:
Tests successfully made:
rtp
object is not present everything works as expected.netstat
that the existing socket is correctly changed afterconfigure
request. We have seen that both way RTP sessions are OK and both way audio communication is well established. the socket is closed after participant left or after session close.confiure
rtp
requests on a single session works fineallowRtpParticipants
isfalse
on room, (2)join
event does not containrtp
Not Tested:
payload_type
changes onconfigure
is not tested