Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register plugin routes before the Medusa core routes #7395

Merged
merged 1 commit into from
May 22, 2024

Conversation

thetutlage
Copy link
Contributor

Load plugin routes before the Medusa core routes, since it will allow the plugin to define routes with higher priority than Medusa. Here are couple of examples.

  • Plugin registers a route called "/products/active"
  • Medusa registers a route called "/products/:id"

Now, if Medusa routes gets registered first, then the /products/active route will never be resolved, because it will be handled by the /products/:id route.

@thetutlage thetutlage requested a review from a team as a code owner May 22, 2024 09:38
Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
medusa-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 9:38am
3 Ignored Deployments
Name Status Preview Comments Updated (UTC)
api-reference ⬜️ Ignored (Inspect) May 22, 2024 9:38am
docs-ui ⬜️ Ignored (Inspect) May 22, 2024 9:38am
medusa-docs ⬜️ Ignored (Inspect) May 22, 2024 9:38am

Copy link

changeset-bot bot commented May 22, 2024

⚠️ No Changeset found

Latest commit: 32748fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@sradevski sradevski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to revisit our entire routing TBH as it is a bit of a mess, but this works for now

Copy link
Member

@adrien2p adrien2p left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, as discussed, a bigger work will have to be done for the route loading

Copy link
Contributor

@riqwan riqwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

packages/medusa/src/loaders/api.ts Show resolved Hide resolved
@thetutlage thetutlage merged commit ff5d573 into develop May 22, 2024
17 checks passed
@thetutlage thetutlage deleted the refactor/routes-loading-order branch May 22, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants