Added resource validation to MockClient #4559
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Ignored Deployments
|
rahul1
commented
May 15, 2024
| @@ -155,60 +161,6 @@ describe('App', () => { | |||
| mockServer2.stop(); | |||
| }); | |||
|
|
|||
| test('Empty endpoint URL', async () => { | |||
There was a problem hiding this comment.
Removed this test b/c the resource validator prevents Endpoints w/ empty addresses from being created
rahul1
added
the
fhir-datastore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a call to
validateResourceon theMemoryRepoclass, primarily used by MockClient.This actually discovered a bunch of invalid resources in our preloaded
MockClientresources.Unfortunately, it also meant that we had to revert some of the work from #4286, as this compression created invalid StructureDefinitions that wouldn't validate