Optimize database reindex #4558
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattwiller
added
the
fhir-datastore
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Ignored Deployments
|
|
|
|
||
| const lastUpdated = resource.meta?.lastUpdated as string; | ||
| currentTimestamp = lastUpdated; | ||
| await this.withTransaction(async (conn) => { |
There was a problem hiding this comment.
Is this transaction necessary? Trying to imagine what it's needed for, versus letting the callback handle it.
There was a problem hiding this comment.
Hm, I see, you're using this to avoid per-resource transactions in the reindex step.
imho, that kinda breaks the abstraction of forAllResources
- I'm not sure the transaction is fully necessary in
reindexResource - If it is both necessary and if this is a major performance win, then i think we should probably modify the API contract of
forAllResources(maybe a "page" callback and a "resource" callback?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In testing on localhost over resource types with 15k – 100k resources in the table, this combination of transaction batching and concurrent handling of the lookup tables reduced the overall full reindex time by 30–50% (saving on the order of several minutes for my small data set).
This PR also moves the reindex logic into an async worker that processes a batch of rows and then enqueues another job to handle the next chunk. This makes the job much more robust, and allows it to more safely run for extended periods of time.