Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(web/api): mention charset in the demo #33690

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(web/api): mention charset in the demo #33690

wants to merge 2 commits into from

Conversation

OnkarRuikar
Copy link
Contributor

It is not easy to realise that charset can also be mentioned in the constructor options. It is trivial but very important setting.

@OnkarRuikar OnkarRuikar requested a review from a team as a code owner May 21, 2024 02:17
@OnkarRuikar OnkarRuikar requested review from sideshowbarker and removed request for a team May 21, 2024 02:17
@github-actions github-actions bot added Content:WebAPI Web API docs size/xs 0-5 LoC changed labels May 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 21, 2024 •
edited

Preview URLs

(comment last updated: 2024-06-01 01:18:14)

sideshowbarker
sideshowbarker reviewed May 21, 2024
View reviewed changes
Copy link
Collaborator

@sideshowbarker sideshowbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I am not sure that on balance it’s helpful to users in 2024 to point out that they can specify a charset there. They should just always be using UTF-8, which is what it will default to if they don’t manually specify it. They should never need to specify any other character encoding, as far as I can see.

All that said, I don’t feel very strongly about it and would not object to it being merged — I’m just not enthusiastic about being the one to push the merge button on it.

So you probably want to ask another reviewer to review and merge this one.

@github-actions GitHub Actions
Copy link
Contributor

This pull request has merge conflicts that must be resolved before it can be merged.

@OnkarRuikar
Copy link
Contributor Author

OnkarRuikar commented Jun 1, 2024 •
edited

They should just always be using UTF-8, which is what it will default to if they don’t manually specify it. They should never need to specify any other character encoding, as far as I can see.

Not sure if the encoding always defaults to UTF-8. Suggesting this change considering this StackOverflow answer: https://stackoverflow.com/a/78506250/15273968

@sideshowbarker
Copy link
Collaborator

sideshowbarker commented Jun 1, 2024 •
edited

They should just always be using UTF-8, which is what it will default to if they don’t manually specify it. They should never need to specify any other character encoding, as far as I can see.

Not sure if the encoding always defaults to UTF-8. Suggesting this change considering this StackOverflow answer: stackoverflow.com/a/78506250/15273968

Yeah, I don’t know whether that answer is actually correct. It may well be, but I’m not familiar enough with the spec requirements to know. So it may be worthwhile to seek out some specific technical review — for example, from one of the spec editors, or from someone else who’s done technical review for us in the past on any related patches/PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sideshowbarker sideshowbarker sideshowbarker left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Content:WebAPI Web API docs size/xs 0-5 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@OnkarRuikar @sideshowbarker