Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Intl.DateTimeFormat.resolvedOptions dateStyle, timeStyle #33634

Merged
merged 10 commits into from
Jun 11, 2024
Merged

Add Intl.DateTimeFormat.resolvedOptions dateStyle, timeStyle #33634

merged 10 commits into from
Jun 11, 2024

Conversation

medmunds
Copy link
Contributor

Description

Document dateStyle and timeStyle for Intl.DateTimeFormat.resolvedOptions() return value.

Motivation

These properties were added in tc39/ecma402#457, but are not covered by the current documentation.

Additional details

See current https://tc39.es/ecma402/#table-datetimeformat-resolvedoptions-properties

Related issues and pull requests

@medmunds medmunds requested a review from a team as a code owner May 16, 2024 01:53
@medmunds medmunds requested review from Josh-Cena and removed request for a team May 16, 2024 01:53
@github-actions github-actions bot added Content:JS JavaScript docs size/xs 0-5 LoC changed labels May 16, 2024
Josh-Cena
Josh-Cena reviewed May 19, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I'm in the process of updating these docs but it's good to make them more correct. I just have one question.

...s/en-us/web/javascript/reference/global_objects/intl/datetimeformat/resolvedoptions/index.md Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 20, 2024 •
edited

Preview URLs

Flaws (1)

Note! 1 document with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/resolvedOptions
Title: Intl.DateTimeFormat.prototype.resolvedOptions()
Flaw count: 1

  • broken_links:
    • Can't resolve /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/Locale/getTimeZoneNames
External URLs (1)

URL: /en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/DateTimeFormat/DateTimeFormat
Title: Intl.DateTimeFormat() constructor

(comment last updated: 2024-06-10 18:56:07)

@github-actions github-actions bot added size/s 6-50 LoC changed and removed size/xs 0-5 LoC changed labels Jun 5, 2024
medmunds and others added 4 commits June 5, 2024 13:56
@medmunds
Document dateStyle, timeStyle resolved options
3325377 
(See current https://tc39.es/ecma402/#table-datetimeformat-resolvedoptions-properties)
@medmunds @github-actions
Lint
e6d828b 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@medmunds
Update from review feedback
0e9b846 
- Clarify dateStyle and timeStyle
- Add example
- Add missing hourCycle
- Clarify calendar and numberingSystem
@medmunds @github-actions
lint
913dc87 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added size/m 51-500 LoC changed and removed size/s 6-50 LoC changed labels Jun 10, 2024
Josh-Cena
Josh-Cena approved these changes Jun 10, 2024
View reviewed changes
Copy link
Member

@Josh-Cena Josh-Cena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks! As I mentioned, I already have stashed work locally that aims to unify the format of all resolvedOptions pages, so I took this opportunity to apply that format. I have made sure to incorporate your changes.

Also as suggested I updated the constructor page slightly. I hope everything looks good!

medmunds
medmunds commented Jun 10, 2024
View reviewed changes
Copy link
Contributor Author

@medmunds medmunds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better wording, thanks! Flagged a couple of potential issues inline.

files/en-us/web/javascript/reference/global_objects/intl/datetimeformat/datetimeformat/index.md Outdated Show resolved Hide resolved
files/en-us/web/javascript/reference/global_objects/intl/datetimeformat/datetimeformat/index.md Show resolved Hide resolved
@Josh-Cena
Copy link
Member

Is this ready for merging?

@medmunds
Copy link
Contributor Author

Is this ready for merging?

I think so. Thanks!

@Josh-Cena Josh-Cena merged commit 7c47174 into mdn:main Jun 11, 2024
8 checks passed
@Josh-Cena
Copy link
Member

Great, welcome aboard! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@Josh-Cena Josh-Cena Josh-Cena approved these changes

Assignees
No one assigned
Labels
Content:JS JavaScript docs size/m 51-500 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@medmunds @Josh-Cena