no more vars in Web/API (2) #18864
Merged
no more vars in Web/API (2) #18864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* See mdn#16662 * See #10389 * See https://github.com/orgs/mdn/discussions/143 * Mostly automated via my ESLint setup, using the rules 'no-var' and 'prefer-const'
lionralfs
commented
Jul 27, 2022
This comment was marked as resolved.
This comment was marked as resolved.
| @@ -47,7 +47,7 @@ None ({{jsxref("undefined")}}). | |||
| Here is a very simple example: | |||
|
|
|||
| ```js | |||
| var Mytag = document.registerElement('my-tag'); | |||
| const Mytag = document.registerElement('my-tag'); | |||
There was a problem hiding this comment.
Suggested change
| const Mytag = document.registerElement('my-tag'); | |
| const myTag = document.registerElement('my-tag'); |
There was a problem hiding this comment.
I think this should stay the way it is, the following section reads:
Now the new tag is registered in the browser. The
Mytagvariable holds a
constructor that you can use to create amy-tagelement in the document as
follows:document.body.appendChild(new Mytag());
Co-authored-by: rubiesonthesky <[email protected]>
teoli2003
requested changes
Jul 28, 2022
files/en-us/web/api/cssstyledeclaration/msgetpropertyenabled/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/cssstyledeclaration/msputpropertyenabled/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/datatransferitem/getasfilesystemhandle/index.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Jean-Yves Perrier <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
varin Web/API withconstwhere applicable andletotherwise.Mostly automated via my ESLint setup, using the rules
no-varandprefer-constMotivation
Metadata