Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter to getDynamicRules and getSessionRules #23114

Merged

Conversation

rebloor
Copy link
Collaborator

@rebloor rebloor commented May 16, 2024

Summary

Address browser compatibility documentation requirements for Bug 1820870 [DNR] Add ruleIds filter to getDynamicRules and getSessionRules

Related issues

Related MDN changes: mdn/content#33646

@rebloor rebloor added the data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions label May 16, 2024
@rebloor rebloor requested a review from willdurand May 16, 2024 19:12
@rebloor rebloor self-assigned this May 16, 2024
},
"firefox_android": "mirror",
"opera": "mirror",
"safari": {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willdurand do we have any information on Safari implementation?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @xeenon, can you help here? Thanks!

Copy link
Contributor

@xeenon xeenon May 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@willdurand @rebloor Safari does not support filter currently.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xeenon

@rebloor rebloor marked this pull request as ready for review May 22, 2024 02:51
@rebloor rebloor merged commit df03de2 into mdn:main May 22, 2024
6 checks passed
@rebloor rebloor deleted the ruleIds-e-to-getDynamicRules-and-getSessionRules branch May 22, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:webext 🎲 Compat data for Browser Extensions. https://developer.mozilla.org/Add-ons/WebExtensions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants