Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default filename for plot_residuals like other plots #9

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

japhir
Copy link

@japhir japhir commented Sep 10, 2021

No description provided.

@mdaeron
Copy link
Owner

mdaeron commented Sep 11, 2021

I need to go back to the various plotting functions, but you're right that they lack consistency. The thing to decide first is what should be the default behavior?

  • return a matplotlib Figure object by defaut, which means that most aspects of the figure may be modified before displaying/saving it; return None and save to disk with some optional parameter (e.g. output = 'savefig')
  • return None and save to disk by default; return a Figure object with some optional parameter (e.g. output = 'fig')

In both cases, output = 'ax' could be used to ask for a matplotlib Axes object, which allows including the plot in a larger figure.

Any opinion on the best default behavior? Any change needs to be deliberate because it will (slightly) break backward compatibility.

@japhir
Copy link
Author

japhir commented Sep 13, 2021

I made an issue to discuss what to do, then this can remain the "implementation" branch, which might end up trashed ;-).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants