ext: fiat: Use user-defined assert macro #1881
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The libc assert macro was used in curve25519.c even if the user provided its own definition of the assert macro for MCUboot through mcuboot_assert.h. This commit fixes this issue. Signed-off-by: Thomas Altenbach <[email protected]>
de-nordic
approved these changes
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By defining
MCUBOOT_HAVE_ASSERT_H, a user can configure MCUboot to use a custom definition of theassertmacro, defined inmcuboot_config/mcuboot_assert.hinstead of the one coming from the C standard library.However, the libc's
assertmacro was used incurve25519.ceven ifMCUBOOT_HAVE_ASSERT_His defined. This PR fixes this issue by removing#include <assert.h>fromcurve25519.cto rely instead of theassertdefinition frombootutil/bootutil_public.h.