Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

finished documentation on vizro-core #485

Merged
merged 31 commits into from
May 20, 2024
Merged

finished documentation on vizro-core #485

merged 31 commits into from
May 20, 2024

Conversation

kaestro
Copy link
Contributor

@kaestro kaestro commented May 15, 2024

Description

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

kaestro and others added 30 commits April 21, 2024 22:49
@kaestro
Minor changes on explore-components
72130f5 
Needs to be reviewed whether this is what issue wants and follows the
style guide.
@kaestro
Merge branch 'mckinsey:main' into main
db9ec70
@kaestro
minor changes on document contributing.md
34fdf74
@kaestro
Merge remote-tracking branch 'refs/remotes/origin/main'
4057335
@kaestro
Merge branch 'mckinsey:main' into main
c4bcca7
@kaestro
Minor change in contributing.md file
2e67ed1
@kaestro
Merge branch 'mckinsey:main' into main
7ced630
@kaestro
Vizro AI quicsktart link fixed
0d41358
@kaestro
minor changes on graph
9c4dfe8
@kaestro
minor changes on table
0ec161d
@kaestro
Minor changes on cards & buttons
bc85309
@kaestro
Merge branch 'mckinsey:main' into main
cba850f
@kaestro
minor changes on container.md
7cd4326
@kaestro
Redirected contributing to right one
f1d2af6
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
82744bd 
for more information, see https://pre-commit.ci
@kaestro
ChangeLog Added
4fc1ed3
@kaestro
Changed explore-components by Microsoft standard
f1fad60 
provide => offer, js => JavaScript
@kaestro
Removed Extra changeLog
4beb991
@stichbury
Merge branch 'main' into main
db1ea83
@stichbury @huong-li-nguyen
Update CONTRIBUTING.md
383f302 
Co-authored-by: Li Nguyen <[email protected]>
Signed-off-by: Jo Stichbury <[email protected]>
@stichbury
Merge branch 'main' into main
5d6376c
@kaestro @stichbury
Update vizro-core/docs/pages/user-guides/card-button.md
c5fef6e 
Co-authored-by: Jo Stichbury <[email protected]>
Signed-off-by: 김태홍 <[email protected]>
@kaestro @stichbury
Update vizro-core/docs/pages/user-guides/card-button.md
4457549 
Co-authored-by: Jo Stichbury <[email protected]>
Signed-off-by: 김태홍 <[email protected]>
@kaestro @stichbury
Update vizro-core/docs/pages/user-guides/table.md
7b8f7da 
Co-authored-by: Jo Stichbury <[email protected]>
Signed-off-by: 김태홍 <[email protected]>
@stichbury
Merge branch 'main' into main
e253773
@stichbury
Merge branch 'main' into main
4cbc99f
@kaestro
Merge branch 'mckinsey:main' into main
80e071b
@kaestro
Changes in vizro features
847cabd
@kaestro
minor changes in layouts.md
e08da5a
@kaestro
Merge branch 'mckinsey:main' into main
e4d074a
@kaestro kaestro requested a review from stichbury as a code owner May 15, 2024 23:53
stichbury
stichbury approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you 🙏 🌟 🏅

Joseph-Perkins
Joseph-Perkins approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@Joseph-Perkins Joseph-Perkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful! thank you so much 🙌

@kaestro
Copy link
Contributor Author

kaestro commented May 20, 2024

which ci isn't checked for that it isn't merging yet?

@stichbury stichbury enabled auto-merge (squash) May 20, 2024 08:52
@stichbury
Copy link
Contributor

which ci isn't checked for that it isn't merging yet?

I'm investigating this now. Paging @l0uden for some help -- we seem to have stalled in CI and I cannot get this restarted?

@petar-qb petar-qb disabled auto-merge May 20, 2024 09:09
@l0uden l0uden merged commit 7964dc6 into mckinsey:main May 20, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stichbury stichbury stichbury approved these changes

@Joseph-Perkins Joseph-Perkins Joseph-Perkins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kaestro @stichbury @Joseph-Perkins @l0uden