Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Enable parametrisation of dynamic data functions #482

Merged
merged 99 commits into from
May 28, 2024

Conversation

antonymilne
Copy link
Contributor

@antonymilne antonymilne commented May 15, 2024

Description

Completing https://github.com/McK-Internal/vizro-internal/issues/753
Builds on #479 (step 1 of 2)

This PR enables dynamic data function arguments to be parametrised by using vm.Parameter (parameter targets in a format: <target_component>.data_frame.<dynamic_data_argument>).

The focus of this PR is writing docs, unit tests, making the export_data action to take this type of parameter into account. So the refactoring changes in the /actions folder don't need to be reviewed in detail.

Comment out the following configuration inside vizro-core/hatch.toml in case you get a better idea of what happens when caching is enabled.

#DASH_DEBUG = "true"
#VIZRO_LOG_LEVEL = "DEBUG"

TODO


Screenshot

data

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

antonymilne and others added 30 commits May 1, 2024 11:09
Copy link
Contributor

@stichbury stichbury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a few minor suggestions but approving from docs perspective since I'll be unavailable until Wednesday 29th.

Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⭐ Really cool work you two ⭐

Tried to review as carefully as possible, and only found small things where I suggested smth.

Very exciting stuff that will enable a whole range of new usage options.

vizro-core/docs/pages/user-guides/data.md Show resolved Hide resolved
vizro-core/docs/pages/user-guides/data.md Outdated Show resolved Hide resolved
vizro-core/docs/pages/user-guides/actions.md Outdated Show resolved Hide resolved
vizro-core/docs/pages/user-guides/actions.md Outdated Show resolved Hide resolved
@petar-qb petar-qb merged commit 31d706e into main May 28, 2024
33 checks passed
@petar-qb petar-qb deleted the feat/parametrise-dynamic-data branch May 28, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants