Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature configurable scan interval (#29) #41

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

LavermanJJ
Copy link

@LavermanJJ LavermanJJ commented Mar 3, 2023

This PR fixes #29 by making the scan-interval configurable:

  • Add scan-interval as data to be entered when adding the integration (default remains 60s, minimum 5s)
  • Add config-flow migration, updating existing configurations by adding new scan-interval data
  • Add option-flow, allowing to update the scan-interval w/o re-installing the integration

Notes to @mchwalisz :

  • I've developed code within the home-assistant dev-container, using it's default formatting. So please excuse the formatting changes 馃檲
  • I've removed some unused imports. Hope the un-related cleanup is okay

Looking forward for your feedback!

@LavermanJJ LavermanJJ mentioned this pull request Mar 4, 2023
@LavermanJJ
Copy link
Author

New scan-interval option, when installing integration:
integration

Integration offering option flow "configuration":
overview

Options screen:
options

@lennartschulte
Copy link

I don't see the "Configure" Option in the new HA integration overview.

@mdopp
Copy link

mdopp commented Jul 23, 2023

For me i can say, that I can see the config-parameter, and that I am able to enter i.E. "25"

But the build fails due to an unsorted manifest.json (domain, name, rest alphabetical). This has nothing to do with this pull request, but breaks the checks currently. Maybe @LavermanJJ you could also sort this?

@LavermanJJ
Copy link
Author

@mdopp I'd prefer to have it in a separate PR, however, I'd appreciate feedback from @mchwalisz first, before opening further PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make scan interval configurable
3 participants