Add dedicated build in rails environment loading #1129
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbj
force-pushed
the
rails/environment
branch
from
6f7ac46
to
0f353e0
Compare
mbj
force-pushed
the
rails/environment
branch
from
0f353e0
to
8582a57
Compare
mbj
commented
Dec 2, 2020
|
|
||
| def add_rails_matchers | ||
| # This logic sucks, instead rails should be come a match expression | ||
| # possibly allow match expressions like: `ActionController.subclasses` |
There was a problem hiding this comment.
So expressions of the form $Constant.$method would expect to call a method on an object that returns the actual subclasses.
And: $Constant{,.$method} would match both the constant and the classes returned by the subclass.
We'd than still need an expression for the "entirety" of rails owned constants which could be: <Rails> or similar.
mbj
force-pushed
the
rails/environment
branch
from
8582a57
to
3c64424
Compare
mbj
commented
Dec 2, 2020
| ApplicationController, | ||
| *ApplicationController.subclasses, | ||
| ApplicationRecord, | ||
| *ApplicationRecord.subclasses |
There was a problem hiding this comment.
There is likely way more that should be included in here.
mbj
force-pushed
the
rails/environment
branch
from
3c64424
to
62f3263
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.