Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSV Transaction Imports #708

Merged
merged 68 commits into from May 17, 2024
Merged

CSV Transaction Imports #708

merged 68 commits into from May 17, 2024

Conversation

zachgoll
Copy link
Collaborator

@zachgoll zachgoll commented May 2, 2024

Overview

The overall strategy is to:

  1. Accept any valid CSV format
  2. Allow user to map their columns to our Transaction columns
  3. Once mapped and data is cleaned, we'll initiate an import that creates Transaction records using records and the mappings from Import

A note on inheritance

In the future, we will likely introduce different types of data imports. For example, "Transaction Import", "Account Import", "Category Import".

This initial implementation introduces a broad superclass, Import, and does not account for inheritance. My main reasoning is to avoid a premature implementation.

In this PR

  • A layout refactor (since we'll need another layout for this flow)
  • Basic import flow (happy path)

@zachgoll zachgoll marked this pull request as draft May 3, 2024 12:25
@zachgoll zachgoll marked this pull request as ready for review May 14, 2024 17:35
@Shpigford Shpigford mentioned this pull request May 15, 2024
@zachgoll zachgoll changed the title CSV Transaction Imports: Part 1 CSV Transaction Imports May 16, 2024
@zachgoll zachgoll merged commit 45ae4a9 into main May 17, 2024
4 checks passed
@zachgoll zachgoll deleted the csv-imports-part-1 branch May 17, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant