emoji: Handle conflict with system emojis #518
Conversation
There was a problem hiding this comment.
Hey @kc9jud 👋, thank you for reporting this and giving a shot at fixing it
Looks like there are blockers to properly fix it though, please see my comment below.
Once this is unblocked, if you are able to add a simple test attempting to create a dummy emoji with a conflicting name, that would be great
| emoji_name=self._name, files={"image": image} | ||
| ) | ||
| except InvalidOrMissingParameters as e: | ||
| if e.args and "Name conflicts with existing system emoji name" in e.args[0]: |
There was a problem hiding this comment.
The message field is internationalized, so it depends on the selected language. We should check the error id instead, model.emoji.system_emoji_name.app_error in this case.
The driver does not exposed it:
I am not sure if it is still maintained, I have opened an issue to investigate replacing it: #541. So I think we might be blocked here until we change the driver and the new one exposes the error ID
Fixes #517.