[UI] Dashboard widgets #13734
Draft
[UI] Dashboard widgets #13734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersonjeccel
added
T1
shinde-rahul
approved these changes
May 8, 2024
kuzmany
approved these changes
May 8, 2024
|
Measuring the contrast, the text vs background is well within the strictest WCAG guidelines. The blue links, as well as the dark grey tooltip bubble with grey text, are very low contrast. Would be best to make that blue darker and the text in the bubble lighter. |
|
I'll leave this as draft for a while until the other fixes happen for the items on top 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR increases the widget padding on the dashboard, removes its borders and adds a light grey background color. These changes are part of contrast fixes and modernizes the interface.
This PR is based on another PR, where I introduce tokens to replace most of the UI variables, aiming to improve consistency in all components. We need it to be merged before this one becomes available for code review.
Before:
After:
Steps to test this PR: