New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: works when Gitlab runner is not at the same machine as Gitlab #289
base: main
Are you sure you want to change the base?
Conversation
code-review-gpt/yarn.lock
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this lock file
code-review-gpt/package.json
Outdated
@@ -11,7 +11,7 @@ | |||
"lint-fix": "eslint . --ext=js,ts,tsx --fix", | |||
"lint-test": "eslint . --ext=js,ts", | |||
"start": "ts-node ./src/index.ts", | |||
"review": "ts-node ./src/index.ts review", | |||
"review": "ts-node ./src/index.ts review --model=gpt-3.5-turbo --debug=true", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove this
DiscussionNotePositionOptions, | ||
Gitlab, | ||
} from "@gitbeaker/rest"; | ||
// eslint-disable-next-line import/no-extraneous-dependencies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you need this?
Hey thanks very much for your contribution. I love the better GitLab implementation. Unfortunately, I can't merge it as is.
Many thanks, Matt |
Sorry. I guess I will send 2 PRs - one with the bug fixes and another one with the gitlab staff. I will not touch emoji and other things. Will it be okay? |
I still cant merge this. Please can you check the diff. |
Any news about this? It would be great to have a better Gitlab integration. Thanks! |
Sorry, I am really too busy now :( Also, feel free to just get any code you find useful |
Hello,
Thank you for this great product.
This little patch fixes the following issue with Gitlab integration:
Currently, it uses localhost to communicate with GitLab via API.
While in most real-life installations, gitlab runners and gitlab itself run on different machines,
So, localhost does not work.
Fortunately, gitlab has a special environment variable with its url.
The patch uses it. The patch was tested in a real environment.