improve string->number #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrvidal
commented
May 16, 2024
Comment on lines
+143
to
144
| (svalue @ SteelVal::NumV(_), _) => Ok(svalue), | ||
| _ => Ok(SteelVal::BoolV(false)), |
There was a problem hiding this comment.
I think I could try to handle all types of numbers, but I might need to expose some of the internals of number tokenization to avoid more duplication.
mattwparas
reviewed
May 20, 2024
Co-authored-by: Matthew Paras <[email protected]>
mattwparas
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some minor improvements to
string->numberTODO