Skip to content
This repository has been archived by the owner on Jan 8, 2023. It is now read-only.

feat: adding support for Glob patterns in root #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ryangall7
Copy link

@ryangall7 ryangall7 commented May 25, 2022

What does this implement/fix? Explain your changes.

Adding support for glob patterns in the root attribute.

Any other comments?

The watcher works natively with globs so it was an easy fix to just add ** to the end of the watch paths. Getting the remote path was a bit more tricky, path.relative() doesn't support glob so I used a glob to regex package to get regex and manually removed the end of string $ part to match and replace base paths. It doesn't seem ideal but it does work.

Checklist

Check all those that are applicable and complete. Put an x between the brackets (without spaces).

  • Merged with latest master branch
  • Travis CI passes (Linux support)
  • Added new test (if necessary) to spec directory

@matteobertoldo
Copy link
Owner

@ryangall7 Hi! 😊 Thank u so much for this PR, I would need some time to code review these changes. In these following days I will keep you updated on the possible merge to be carried out.

Thanks again, Matteo.

@ryangall7
Copy link
Author

Thanks, Matteo, this is my first foray into atom plugins so I welcome any feedback!

@ryangall7
Copy link
Author

@matteobertoldo just wanted to let you know this causes an issues with the "Upload All Cartridges" action. I'll work on a fix.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants