supporting reader linear search on unsorted fake pk col #16398
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gouhongshen
requested review from
XuPeng-SH,
LeftHandCold,
triump2020 and
aunjgr
as code owners
gouhongshen
force-pushed
the
support_linear_search_on_fake_pk_col
branch
from
b40c5be
to
af39b76
Compare
check err before add observer Approved by: @XuPeng-SH
…rigin#16386) refactor the code that do not allow the same tunnel in the queue before the tunnel finished tranferring. reset transferred back to false together with wg.Done. Approved by: @zhangxu19830126
add bvt test case for delay Ranges partitioned table Approved by: @heni02
Fix rollback create table. When rollback, the last MVCC node has already removed. Remove related name list node with table.FullName. Approved by: @XuPeng-SH
fix snapshot restore with foreign key cross db Approved by: @daviszhen
…16350)" (matrixorigin#16400) This reverts commit e4c504a. ## What type of PR is this? - [ ] API-change - [ ] BUG - [ ] Improvement - [ ] Documentation - [ ] Feature - [ ] Test and CI - [ ] Code Refactoring ## Which issue(s) this PR fixes: issue #matrixorigin#16379 ## What this PR does / why we need it: revert to avoid oom
…origin#16364) changes: 1. count mo do logic Flush op, see CountPacket() 2. calculate basic number of tcp packets written to client, base on the write buffer size 4096 byte. 3. add bvt case, verify the basic result. Approved by: @daviszhen, @qingxinhome, @heni02
add test for restore view table Approved by: @heni02, @daviszhen
handle CloneSnapshotOp DATA RACE https://github.com/matrixorigin/ci-test/actions/runs/9219842701 Approved by: @zhangxu19830126
changes: 1. QueryResult get query's meta from StmtProfile - Session.tStmt is used only to record the StatementInfo. 2. QueryResult runs fine under situation: tStmt is nil. 3. Logutil runs fine if tStmt is nil. Approved by: @daviszhen
changes: 1. return new txnOp while call txnClinet.New in UT/TestKill. Approved by: @daviszhen
Replace ```sql select name, type, column_name from mo_catalog.mo_indexes mi where mi.column_name ="name" or mi.column_name="__mo_alias_id"; ``` To ```sql select name, type, column_name from mo_catalog.mo_indexes mi where name="idx5"; ``` to match the set of other queries in that BVT file. Approved by: @heni02
…rixorigin#15997) Newly added Files table in the InformationScheme system database, compatible with MySQL client tools Approved by: @daviszhen, @zhangxu19830126, @heni02
Fix panic during merge when some objects are empty Approved by: @XuPeng-SH
more metrics Approved by: @zhangxu19830126
Not set object created by CN as 1PC node Approved by: @XuPeng-SH
…6405) 1. remove the old fast path 2. update ranges metrics. 3. remove some unused codes related to un-serialized composite primary key Approved by: @triump2020, @aptend, @XuPeng-SH
support restore system table Approved by: @daviszhen, @ouyuanning, @heni02
When the cache evicts, although the values in cache's shards are deleted, there are still references in queue1, so fix. ___ ### **PR Type** Bug fix ___ ### **Description** - Fixed an issue in the FIFO cache eviction process where dequeued values were not reset, causing lingering references in the queue. - Ensured that the dequeued value is set to its zero value after removal. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix </strong></td><td><table> <tr> <td> <details> <summary><strong>queue.go</strong><dd><code>Fix lingering references in FIFO cache eviction</code> </dd></summary> <hr> pkg/fileservice/fifocache/queue.go <li>Reset the dequeued value to its zero value to ensure no lingering <br>references.<br> </details> </td> <td><a href="https://github.com/matrixorigin/matrixone/pull/16450/files#diff-d12dc3e07f526032523b1f79c92551e4794b2a6f61b662e766ca4d9464c183de">+2/-0</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions Approved by: @reusee
fix drop publication if exists statement ___ ### **PR Type** Bug fix, Tests ___ ### **Description** - Added condition to handle `IF EXISTS` clause in `DROP PUBLICATION` statement to prevent internal errors when the publication does not exist. - Added tests to verify the behavior of the `DROP PUBLICATION IF EXISTS` statement. - Included setup and teardown steps in the test cases to ensure proper testing environment. ___ ### **Changes walkthrough** 📝 <table><thead><tr><th></th><th align="left">Relevant files</th></tr></thead><tbody><tr><td><strong>Bug fix </strong></td><td><table> <tr> <td> <details> <summary><strong>authenticate.go</strong><dd><code>Handle `IF EXISTS` clause in `DROP PUBLICATION` statement</code></dd></summary> <hr> pkg/frontend/authenticate.go <li>Added condition to handle <code>IF EXISTS</code> clause in <code>DROP PUBLICATION</code> <br>statement.<br> <li> Prevented internal error when publication does not exist and <code>IF EXISTS</code> <br>is specified.<br> </details> </td> <td><a href="https://github.com/matrixorigin/matrixone/pull/16449/files#diff-849f201c351210bd95807e99d1538e2602a5244b256c35e58467afe304c509e6">+5/-1</a> </td> </tr> </table></td></tr><tr><td><strong>Tests </strong></td><td><table> <tr> <td> <details> <summary><strong>pub_sub2.result</strong><dd><code>Add tests for `DROP PUBLICATION IF EXISTS` statement</code> </dd></summary> <hr> test/distributed/cases/tenant/pub_sub2.result <li>Added tests for <code>DROP PUBLICATION IF EXISTS</code> statement.<br> <li> Verified behavior when publication does not exist.<br> </details> </td> <td><a href="https://github.com/matrixorigin/matrixone/pull/16449/files#diff-b8d12747873e9eca46444acc746b3157e5715dcee599fa5353c036a19b550b13">+7/-0</a> </td> </tr> <tr> <td> <details> <summary><strong>pub_sub2.sql</strong><dd><code>Add SQL commands to test `DROP PUBLICATION IF EXISTS`</code> </dd></summary> <hr> test/distributed/cases/tenant/pub_sub2.sql <li>Added SQL commands to test <code>DROP PUBLICATION IF EXISTS</code>.<br> <li> Included setup and teardown steps for the test.<br> </details> </td> <td><a href="https://github.com/matrixorigin/matrixone/pull/16449/files#diff-d185c58ec352113c102571a08f1f6b69a4cb33e75b69c5d6ed221cbc47c7df91">+12/-1</a> </td> </tr> </table></td></tr></tr></tbody></table> ___ > 💡 **PR-Agent usage**: >Comment `/help` on the PR to get a list of all available PR-Agent tools and their descriptions Approved by: @daviszhen, @heni02
matrix-meow
added
size/XL
gouhongshen
requested review from
zhangxu19830126,
volgariver6,
aptend,
ouyuanning,
badboynt1,
daviszhen,
qingxinhome,
reusee,
aressu1985 and
heni02
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue ##13959
What this PR does / why we need it:
supporting reader linear search on unsorted fake pk col