add txn id

[daviszhen]

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue ##16393

What this PR does / why we need it:

在query trace status的日志中增加txnId

[matrix-meow]

@daviszhen Thanks for your contributions!

Pull Request Review:

Title:

The title of the pull request is clear and concise, indicating the addition of a transaction ID.

Body:

The body of the pull request provides relevant information about the type of PR, the linked issue, and the purpose of the changes. It specifies the addition of a transaction ID to the query trace status logs.

Changes:

1. In mysql_cmd_executor.go:

   • Added the following code snippet:

     ses.SetTxnId(txnOp.Txn().ID)

   • This change sets the transaction ID in the session.

2. In util.go:

   • Modified the logging statement to include the transaction ID:

     txnId := ses.GetTxnId()
     ses.Error(ctx, "query trace status", logutil.StatementField(str), logutil.StatusField(status.String()), logutil.ErrorField(err),
         logutil.TxnIdField(hex.EncodeToString(txnId[:])))

   • This change includes the transaction ID in the log message for query trace status.

Feedback and Suggestions for Improvement:

1. Security Issue - Hex Encoding Transaction ID:

   • Encoding the transaction ID using hex.EncodeToString(txnId[:]) in the log message may expose sensitive information. It's recommended to avoid directly logging transaction IDs in a readable format as it can potentially leak sensitive data. Consider hashing or obfuscating the transaction ID before logging it.

2. Optimization - Redundant Transaction ID Retrieval:

   • In util.go, the transaction ID is retrieved using ses.GetTxnId() before logging it. It would be more efficient to directly access the transaction ID where needed instead of retrieving it separately. This can improve performance by reducing unnecessary function calls.

3. Consistency in Comments:

   • Ensure consistent commenting style throughout the codebase. For example, the comment //refresh txn id in mysql_cmd_executor.go lacks context and could be more descriptive to explain the purpose of setting the transaction ID.

4. Error Handling:

   • Ensure proper error handling mechanisms are in place, especially when dealing with sensitive data like transaction IDs. Validate error scenarios and provide appropriate error messages or fallback mechanisms.

5. Code Readability:

   • Consider adding comments or documentation to explain the purpose of setting and using the transaction ID in the code. This can help other developers understand the functionality more easily.

6. Testing:

   • It's essential to include tests for the changes made to ensure the new functionality works as expected and does not introduce regressions.

7. Review Logging Practices:

   • Review the logging practices in the codebase to ensure sensitive information is not exposed unintentionally. Implement logging best practices to maintain data privacy and security.

By addressing the security issue, optimizing the code for efficiency, and improving code quality through consistent commenting and testing, the pull request can be enhanced to ensure a more secure and efficient implementation.