fix rollback create table

[jiangxinmeng1]

What type of PR is this?

• API-change
• BUG
• Improvement
• Documentation
• Feature
• Test and CI
• Code Refactoring

Which issue(s) this PR fixes:

issue #16282

What this PR does / why we need it:

Fix rollback create table.
When rollback, the last MVCC node has already removed. Remove related name list node with table.FullName.

[CLAassistant]

All committers have signed the CLA.

[matrix-meow]

@jiangxinmeng1 Thanks for your contributions!

Pull Request Review:

Title:

The title of the pull request is clear and concise, indicating that the purpose of the PR is to fix an issue related to rollback create table.

Body:

The body of the pull request provides relevant information about the type of PR (BUG), the specific issue it fixes (issue #16282), and the reason for the PR (fixing rollback create table). This information is helpful for understanding the context of the changes.

Changes:

1. In the RemoveEntry function in database.go:

   • The code has been added to handle the removal of related name list nodes when rolling back a table creation. This ensures that the name list nodes are properly updated when rolling back a table creation operation.
   • The code checks if the name node exists for the table's full name, deletes the node for the table ID, and removes the name node entirely if it has no more entries associated with it. This is a necessary adjustment to maintain consistency in the database state during rollbacks.

2. In the TestRollbackCreateTable function in db_test.go:

   • A new test case has been added to simulate the creation and rollback of tables in a database.
   • The test creates tables, drops them, and then rolls back the changes to verify the behavior of the rollback process.
   • The test ensures that the rollback mechanism functions correctly in handling table creation and deletion operations.

Suggestions for Improvement:

1. Error Handling: Ensure that error handling is implemented throughout the code where necessary. For example, consider adding appropriate error checks and handling mechanisms in the RemoveEntry function to manage potential errors during node deletion operations.

2. Code Optimization:

   • Consistency: Maintain consistency in variable naming and coding style throughout the codebase for better readability and maintainability.
   • Comments: Consider adding comments to explain the purpose of specific code blocks or complex logic to aid in understanding for future developers.

3. Security Concern:

   • Input Validation: Validate input parameters, especially in functions like RemoveEntry, to prevent potential issues like null pointer dereference or unexpected behavior due to invalid inputs.

4. Testing:

   • Coverage: Ensure that the test coverage is comprehensive, covering various scenarios and edge cases to validate the functionality of the code changes thoroughly.
   • Isolation: Aim to isolate test cases to focus on specific functionalities, making it easier to identify and debug issues if they arise.

5. Documentation:

   • Update Documentation: If there are any changes to the public API or behavior, ensure that the documentation is updated accordingly to reflect the modifications made in this PR.

By addressing these suggestions, the codebase can be enhanced in terms of reliability, maintainability, and security. Additionally, optimizing the code and ensuring thorough testing will contribute to a more robust and stable system.