remove unused bucket logic in hash table #16103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badboynt1
requested review from
m-schen,
ouyuanning,
aunjgr and
XuPeng-SH
as code owners
badboynt1
changed the title
ouyuanning
approved these changes
May 14, 2024
m-schen
approved these changes
May 14, 2024
aunjgr
approved these changes
May 14, 2024
XuPeng-SH
approved these changes
May 14, 2024
… removebucket Conflicts: pkg/pb/pipeline/pipeline.pb.go
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue(s) this PR fixes:
issue #15967
What this PR does / why we need it:
最早为了解决某些情况下hash表太大的问题，用了给hash表分桶的写法。
后来实现了shuffle以后，就不再需要这些分桶的逻辑了，移除这些冗余代码，为之后的重构减少负担