fix some metrics and update code owners (#12299)

matrixorigin · Oct 24, 2023 · 04a8a19 · 04a8a19
1 parent d65f651
commit 04a8a19
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/CODEOWNERS b/CODEOWNERS
@@ -150,6 +150,7 @@
 /pkg/util/toml @zhangxu19830126
 /pkg/util/trace @xzxiong
 /pkg/util/export @xzxiong
+/pkg/util/metric/v2 @zhangxu19830126
 
 # pkg/vectorize
 /pkg/vectorize @aunjgr

diff --git a/pkg/txn/rpc/sender.go b/pkg/txn/rpc/sender.go
@@ -173,10 +173,8 @@ func (s *sender) doSend(ctx context.Context, request txn.TxnRequest) (txn.TxnRes
  if err != nil {
  return txn.TxnResponse{}, err
  }
- defer func() {
- v2.TxnCNSendCommitDurationHistogram.Observe(time.Since(start).Seconds())
- f.Close()
- }()
+ v2.TxnCNSendCommitDurationHistogram.Observe(time.Since(start).Seconds())
+ defer f.Close()
 
  v, err := f.Get()
  if err != nil {

diff --git a/pkg/util/metric/v2/dashboard/grafana_dashboard_txn.go b/pkg/util/metric/v2/dashboard/grafana_dashboard_txn.go
@@ -76,7 +76,7 @@ func (c *DashboardCreator) initTxnOverviewRow() dashboard.Option {
  c.withGraph(
  "Commit requests",
  3,
- "sum(mo_txn_commit_total) by (type)",
+ "sum(rate(mo_txn_commit_total[$interval])) by (type)",
  "{{ type }}"),
 
  c.withGraph(