Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update brew scripts and configs #871

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

jeffbyrnes
Copy link
Contributor

This updates a variety of things related to Homebrew:

  • Drop unnecessarily running brew cleanup & brew update
  • Add, and echo during script run, some suggestions re: $PATH for coreutils, moreutils, and findutils
  • Drop Brew package arguments that are no longer present, and add additional instructions as-needed for gnu-sed (for the others, their defaults are now the same as what the args provided)

Okeanos added a commit to Okeanos/dotfiles that referenced this pull request May 19, 2019
@jeffbyrnes jeffbyrnes force-pushed the update-brew-scripts-and-configs branch from 13b84b4 to bf7e287 Compare July 23, 2019 04:39
addianto added a commit to addianto/dotfiles that referenced this pull request Aug 20, 2019
This commit improves the brew formulaes provisioning script by
checking existence of `brew` command before execution and also
by adding informational messages after installing GNU utilities.
The messages follow the content found in the following Pull
Request on GitHub: mathiasbynens/dotfiles#871
brew.sh Outdated Show resolved Hide resolved
@jeffbyrnes jeffbyrnes force-pushed the update-brew-scripts-and-configs branch from bf7e287 to 8321a9f Compare August 25, 2019 16:02
@jeffbyrnes
Copy link
Contributor Author

Rebased against the latest master for a clean merge.

@jeffbyrnes jeffbyrnes force-pushed the update-brew-scripts-and-configs branch from 8321a9f to f56c8bc Compare October 15, 2019 17:02
@jeffbyrnes
Copy link
Contributor Author

Rebased against latest master for a clean merge.

@jeffbyrnes jeffbyrnes force-pushed the update-brew-scripts-and-configs branch from f56c8bc to 1c32d55 Compare May 3, 2020 22:21
@jeffbyrnes
Copy link
Contributor Author

Rebased again to maintain a clean merge.

@mathiasbynens mathiasbynens changed the base branch from master to main June 16, 2020 07:06
As such, no need to run it separately.

Per Homebrew/brew#50.

This was released way back in Homebrew v1.0.0:
https://brew.sh/2016/09/21/homebrew-1.0.0/
This raises the visibility of this, ensuring someone who runs this
script without reading it (lets face it, that’s a lot of us) is more
strongly encouraged to add to their $PATH.
Let operators know how they can make these the defaults.
Per Homebrew/homebrew-core@068955e8cd, the --with-default-names option
has been removed from the gnu-sed package.

This change:

* Drops the argument, so the install works
* Echos how to add the necessary path to $PATH in order to replicate the
previous behavior (i.e., that gnu-sed is available as sed)

Fixes mathiasbynens#869
This option was removed back in Homebrew/homebrew-core#9873.

As of wget 1.19, support for IDNs is possible via libidn2. Thankfully,
the wget formula requires libidn2 as of Homebrew/homebrew-core#21821

As such, even though the option is dropped, the installation of wget has
the same functionality that the option once provided.
This option was removed in Homebrew/homebrew-core@ae89314d37

Thankfully, it was also made the default behavior, so no loss of
functionality occurs with a new installation.

Fixes mathiasbynens#870
Removed in Homebrew/homebrew-core#34421

Of note: this drops Python 2 support.
@jeffbyrnes jeffbyrnes force-pushed the update-brew-scripts-and-configs branch from 1c32d55 to 3dcde32 Compare December 19, 2020 16:05
@jeffbyrnes
Copy link
Contributor Author

I’ve:

  • Rebased this against main as of today
  • Dropped the removal of brew cleanup, since it's harmless to keep, and maybe you prefer that!

@mathiasbynens this should fix up the brew.sh to work well with Homebrew ≥ 2.0.0

@jeffbyrnes
Copy link
Contributor Author

@mathiasbynens going through some older PRs, and thought I’d give this one a bump. Looks like it’ll still merge cleanly, even if it’s long in the tooth!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No webp for imagemagick No default names for gnu-sed
2 participants