Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] add draft for gruneisen workflow #752

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

naik-aakash
Copy link
Contributor

Summary

This PR aims to add a Gruneisen workflow using phonopy API

Todo

  • Add job to compute Gruneisen parameter to the flow
  • Add tests
  • Add a VASP-compatible flow as well (currently only forcefield flow is added)

@naik-aakash
Copy link
Contributor Author

naik-aakash commented Feb 27, 2024

Hi @JaGeo, @joabustamante and @kaueltzen, just tagging you all here for updates.

Copy link

codecov bot commented Feb 27, 2024

Codecov Report

Attention: Patch coverage is 0% with 51 lines in your changes missing coverage. Please review.

Project coverage is 76.05%. Comparing base (29a5731) to head (fca6b5d).
Report is 30 commits behind head on main.

Current head fca6b5d differs from pull request most recent head fdb7c00

Please upload reports for the commit fdb7c00 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #752      +/-   ##
==========================================
+ Coverage   74.94%   76.05%   +1.10%     
==========================================
  Files         136      116      -20     
  Lines       10513     8557    -1956     
  Branches     1643     1283     -360     
==========================================
- Hits         7879     6508    -1371     
+ Misses       2143     1663     -480     
+ Partials      491      386     -105     
Files Coverage Δ
src/atomate2/common/jobs/gruneisen.py 0.00% <0.00%> (ø)
src/atomate2/forcefields/flows/gruneisen.py 0.00% <0.00%> (ø)

... and 41 files with indirect coverage changes

@JaGeo
Copy link
Member

JaGeo commented Feb 27, 2024

Thanks!

Can we add that we might need to adapt the current optimization in the force fields, as we don't change the cell shape currently and that we need symmetry and potentially checks that the optimization has converged (especially for force fields?)

@tpurcell90
Copy link
Contributor

If you also want to make this more of a common workflow I can add aims support

@JaGeo
Copy link
Member

JaGeo commented Feb 28, 2024

@tpurcell90
Surely. It will take some time though. The current Implementation is the result of a first tiny hackathon that we had to introduce jobflow concepts more widely in the group

@tpurcell90
Copy link
Contributor

Ya no rush on that, just ping me when you want me to take a look at it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants