docs: convert all images to webp #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VandeurenGlenn
changed the title
VandeurenGlenn
force-pushed
the
convert-doc-images-to-webp
branch
from
0c2006f
to
adfb50f
Compare
VandeurenGlenn
changed the title
VandeurenGlenn
changed the title
asyncLiz
changed the title
asyncLiz
reviewed
Apr 10, 2024
asyncLiz
requested changes
Apr 10, 2024
There was a problem hiding this comment.
Same question here as to what changed in the .gif file
There was a problem hiding this comment.
This one has some compression also (around 10%) and 10 of the colors (if I remember correctly).
asyncLiz
approved these changes
May 7, 2024
asyncLiz
changed the title
No worries, when ya busy ya busy ;) |
VandeurenGlenn
force-pushed
the
convert-doc-images-to-webp
branch
from
5905c26
to
7ada3ee
Compare
asyncLiz
requested changes
May 9, 2024
Oeps, maybe I missed that one and is a gif, I'll see what went wrong. |
|
So it seems animated webp exists, I didn't know, converted that one back to original one, if that one needs to be smaller also it would be best to have the input files because the animations have different frame times. |
VandeurenGlenn
added a commit
to VandeurenGlenn/material-web
that referenced
this pull request
May 20, 2024
VandeurenGlenn
changed the title
VandeurenGlenn
force-pushed
the
convert-doc-images-to-webp
branch
from
f177e9b
to
2f0c99a
Compare
VandeurenGlenn
changed the title
asyncLiz
approved these changes
May 20, 2024
copybara-service
bot
merged commit 9233821
into
material-components:main
3 of 4 checks passed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squooshed all PNG images to webp (with the default settings except the effort put to 6)
The material gif has about 10% compression
The other gif about 10% compression and colors set to 10