Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancing RTL Features: Feed Titles Alignment, Tableview Layout Direction Switching, and Message Marking Read #1371

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

RachidTagzen
Copy link
Contributor

I encountered issues with my previous commit operation. As a result, I've made 3 fixed commits along with brief explanations for each:

1. Prevent message to be marked read when it's selected.
2. Feeds' titles alignment from right to left & vice versa.
3. Ability to switch the entire messages Tableview Layout Direction.




Prevent message to be marked read when it's selected

This feature prevents messages from being marked as read automatically when they are selected or clicked on.
It gives users the ability to control when messages are marked as read.

image




Feeds' titles alignement from right to left & vice versa

This feature allows users to choose how the feeds’ titles will be aligned, whether it's from right to left or left to right.

image | image

image




Ability to switch the entire messages Tableview Layout Direction

This feature allows users to switch the direction of the entire messages TableView Layout, allowing for a change between right-to-left and left-to-right orientations.

This feature works correctly and perfectly, it handles all the possible cases that are presented in the following truth table :

Truth table

image

This feature prevents messages from being marked as read automatically when they are selected or clicked on, giving users the ability to control when messages are marked as read within the system.
This update allows users to choose how the title of the feed will be displayed, giving them control over the alignment of the title text, whether it's from right to left or left to right.
This feature allows users to switch the direction of the entire messages TableView Layout, allowing for a change between right-to-left and left-to-right orientations.
@martinrotter
Copy link
Owner

Lets ignore feature 1 for now.

At this point, there is RTL flag which can be set per-feed and also recursively.

image

Setting RTL into feeds is at this point correctly taken into account when displaying FEED list or ARTICLE list. If category contains some RTL and some NON-RTL feeds then both lists will react appropriately.

Category selected (mixed RTL).
image

Category selected (RTL only)
image

Feed selected (RTL)
image

So from my POV your table above is not factually correct. If feed is marked as RTL, then all its content including the article content is displayed as RTL.
image

Maybe I am missing something but current RSS Guard behavior already de-facto behaves like your above table specifies.

That's for the point 3.

As per point 2 - yes, that subfeature could likely be added but I would maybe prefer it to be feed-specific setting which can also be changed globally via "edit recursive child feeds" feature.

@RachidTagzen
Copy link
Contributor Author


Ability to switch the entire messages Tableview Layout Direction

Setting RTL into feeds isn't enough. So, I think you forgot to activate this option in the general settings (otherwise the table truth will not be correct):

Tools -> Settings -> Feeds & articles -> Articles list -> Switch messages tableview direction

For an RTL feed, the best & comfortable Tableview display is to switch its layout totally to right-to-left, not just set individual columns to right-to-left.
Switching individual columns to right-to-left is only useful in the case when the selected category is mixed.
So, my user experience is prefect using my solution.

This video shows how the feature switchs the Tableview layout direction:
https://www.youtube.com/watch?v=yklb8eFdlbM




Feeds' titles alignment from right to left & vice versa

I think that your suggestion is also good.
So why not use my solution and your suggestion at the same time like this :

  • Global settings : as a default setting applied to any feed. (Via Tools -> Settings -> Feeds & articles -> Feeds list)
  • Category settings : applied to this category child feeds. (Via Edit recursive child feeds)
  • Feed settings : applied to this feed. (Via Edit selected items)

The priority logic order must be like this:
"Feed settings" overrides "Category settings" overrides "Global settings"



NB:
Here is my sample database:
database.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants