ICU message format for translations

[flatron4eg]

• I have read the contributing guidelines and I agree with the Code of Conduct
• Have you checked that there aren't other open pull requests for the same changes?
• Have you tested that the committed code can be executed without errors?

---

Added support for MessageFormat from ICU for all the translation lines.

---

[marticliment]

Could you please explain further what ICU does? Thanks!

[flatron4eg]

Here in description of library that I used (see Supported formats) some good examples of formats which can be used. Most used case for russian language for example would be plurals, cause in english you have only two cases - 1 item is without "s" ending and the others - with "s", which you are handling right now directly in the code with "if's" (but with ICU support you can just use line f.e. {0} {0,plural,one {update}, other {updates}} available). In russian (also almost all the slavic languages) there are more cases with different endings, f.e. "яблоко" (an apple) with different numerals before would be "1 яблоко", "2 яблока", "5 яблок" and so on. Also, you can format dates, numbers in different locales, currencies and more.

[flatron4eg]

One more note - Tolgee already handles ICU format: it has highlighting and it shows readable result when translation is saved

[marticliment]

Makes sense. I will test the PR and let you know.

The translation files don't need to be modified?

[flatron4eg]

No, we can just use new functions when translating the lines in Tolgee, old ones will work as before. But there can be one issue - if you support all the old versions and they can fetch new translation lines, if they will use ICU - old versions of WingetUI would not handle them properly, not sure what is the best way to resolve this.

[marticliment]

Hello @flatron4eg, I have been doing testing and I am afraid this PR would break older versions of WingetUI. Therefore, I can't merge it.

[flatron4eg]

@marticliment But since you already changed path to language files with UniGet rebranding (

WingetUI/src/UniGetUI/Core/Data/LanguageData.cs

Line 101 in 527a35a

Uri NewFile = new("https://raw.githubusercontent.com/marticliment/WingetUI/main/src/" + (UseOldUrl? "wingetui": "UniGetUI") + "/Assets/Languages/lang_" + LangKey + ".json");

), older versions will not get any updates from github, cause there are no files on that old path. IMO this is the best moment to make this change.

[marticliment]

That is true, I did not think about that...

[flatron4eg]

Resolved all the conflicts, is there anything else have to be done before merge?

[marticliment]

No, everything should be fine. I will review changes and merge it as soon as I have a moment to do some testing

[marticliment]

Before merging this PR I will merge #2161. Then I will fix the conflicts and do the merge

[flatron4eg]

I know you are busy so I resolved the conflicts and fixed codacy issues. There is one failing test but it seems unrelated

[marticliment]

Thanks❤️

I will check the tests and merge