Fix updateChoropleth Issues #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows numerical subunits in updateChoropleth and reloads subunits that had data previously but don't in the new data being passed to updateChoropleth.
|
I'm currently running updateChoropleth() to reset values, but data is not updating to become blank. Data is for almost all countries |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows numerical subunits in updateChoropleth and reloads subunits that had data previously but don't in the new data being passed to updateChoropleth.
Right now, subunits with numerical IDs (such as maps of US counties) cause an error when trying to run updateChoropleth because they're not valid CSS selectors. CSS.escape() escapes numbers to be used as selectors.
Also, if there is data for a subunit but you try to run updateChoropleth with new data that doesn't include that subunit it doesn't update its data to become blank, leaving some side-effects if you try to access their current fill colour, which updating them to be empty prevents.