New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add endpoints to get/update management permissions on IdP, and delete mapper to IdP #494

Open

Kevin-Bannier wants to merge 1 commit into marcospereirampj:master from Kevin-Bannier:feature/add-idp-endpoints-permissions

+74 −1

Contributor

Kevin-Bannier commented Oct 25, 2023

Add 3 methods to reach endpoints about IdP:

delete_mapper_to_idp
get_idp_management_permissions
update_idp_management_permissions

Kevin-Bannier requested review from ryshoooo and marcospereirampj as code owners

October 25, 2023 12:13


feat: Add endpoints to get/update management permissions on IdP, and

fe39ad3

delete mapper to IdP

Kevin-Bannier force-pushed the feature/add-idp-endpoints-permissions branch from 7863467 to fe39ad3 Compare

October 25, 2023 12:23

Collaborator

ryshoooo commented Nov 13, 2023

Hi @Kevin-Bannier

Thanks a lot for the contribution :) Overall looks good, but could you add unit tests for these new endpoints?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment