Merge pull request #117 from marcbachmann/fix-tmp-dir-path

Fix tmp directory path
marcbachmann · Feb 19, 2016 · 46008df · 46008df
2 parents 891b9e5 + f88cd01
commit 46008df
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 2 deletions.
diff --git a/lib/scripts/pdf_a4_portrait.js b/lib/scripts/pdf_a4_portrait.js
@@ -62,7 +62,7 @@ page.onLoadFinished = function (status) {
  quality: options.quality || 75
  }
 
- var filename = options.filename || (options.directory || '/tmp' + '/html-pdf-' + system.pid + '.' + fileOptions.type)
+ var filename = options.filename || (options.directory || '/tmp') + '/html-pdf-' + system.pid + '.' + fileOptions.type
  page.render(filename, fileOptions)
  system.stdout.write(JSON.stringify({filename: filename}))
 

diff --git a/test/index.js b/test/index.js
@@ -53,7 +53,7 @@ test('pdf.create(html[, options]).toFile([filename, ]callback)', function (t) {
  })
 })
 
-test('pdf.create(html[, options]).toBuffer(callback)', function (t) {
+test('pdf.create(html).toBuffer(callback)', function (t) {
  t.plan(3)
 
  pdf.create(html).toBuffer(function (err, pdf) {
@@ -63,6 +63,15 @@ test('pdf.create(html[, options]).toBuffer(callback)', function (t) {
  })
 })
 
+test('pdf.create(html, {directory: "/tmp"}).toBuffer(callback)', function (t) {
+ t.plan(2)
+
+ pdf.create(html, {directory: '/tmp'}).toBuffer(function (err, pdf) {
+ t.error(err)
+ t.assert(Buffer.isBuffer(pdf), "uses the passed directory as tmp dir")
+ })
+})
+
 test('pdf.create(html[, options]).toStream(callback)', function (t) {
  t.plan(3)