Run on github action on 'main' branch, not just 'master' #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manzanotti
reviewed
Sep 9, 2023
.github/workflows/build-and-test.yml
Outdated
| @@ -4,9 +4,9 @@ | |||
| name: Build and Test | |||
| on: | |||
| push: | |||
| branches: ["master"] | |||
| branches: ["main", "master"] | |||
There was a problem hiding this comment.
As we only have a main branch, couldn't master just be replaced with it, rather than adding main to this array?
manzanotti
approved these changes
Sep 11, 2023
|
As interesting as some of your previous commits on this branch are (seriously, I like the monitoring saving data, that's something I want to add to the Home Assistant plugin at some point), I'd rather not have the commits polluting the git history, even though you've reversed the commits. I've created a PR with your change, and merged it in though, so thank you! |
|
Point noted. I accident merged from the wrong branch. GitHub's Squash and Merge, for PRs is a great boon for such messy pull requests, obviating the need to worry about this sort of thing, and keeping the commit history clean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.