Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: an endpoint without a parent contaminated with its predecessor's parent. #126

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

rczajka
Copy link

@rczajka rczajka commented Jul 29, 2016

The /another-login/ endpoint only worked correctly, because it was preceded by a pattern with an empty parent. Had the previous parent been not empty (as in the amended test), the last pattern would've been rendered as /router/another-login/, because of the parent_pattern variable reuse in the fixed loop.

@StyXman
Copy link
Contributor

StyXman commented Dec 20, 2016

@rczajka you patch is too complex, introduces several features. I prefer to have one feature per PR. It seems to be part #125 , part #117 . Could you confirm?

@rczajka
Copy link
Author

rczajka commented Dec 28, 2016

Yes. Other than the PRs you referenced, there's one-line change in 089f754, which adds .accept("json") to APIRequest, which is important if JSON isn't the API's default format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants