Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce SQL queries for ordering watchlist #797

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jilljenn
Copy link
Member

@jilljenn jilljenn commented Oct 29, 2022

  • The number of queries is drastically reduced
  • Repair tests (some of them make no sense to me)
  • We REMOVE the natsort dependency! ← @RaitoBezarius you should be happy
  • Actually it is not that clever to put available_works in the Django queryset, should fix before review

@jilljenn jilljenn marked this pull request as draft October 29, 2022 23:43
@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #797 (f71666b) into master (6f3471b) will increase coverage by 0.18%.
The diff coverage is 76.78%.

@@            Coverage Diff             @@
##           master     #797      +/-   ##
==========================================
+ Coverage   79.23%   79.42%   +0.18%     
==========================================
  Files          66       66              
  Lines        4561     4549      -12     
==========================================
- Hits         3614     3613       -1     
+ Misses        947      936      -11     
Impacted Files Coverage Δ
mangaki/mangaki/utils/fit_algo.py 85.18% <ø> (ø)
mangaki/mangaki/utils/recommendations.py 94.38% <69.23%> (+7.28%) ⬆️
mangaki/mangaki/utils/profile.py 67.18% <76.31%> (+4.50%) ⬆️
mangaki/mangaki/utils/ratings.py 92.85% <100.00%> (+0.26%) ⬆️
mangaki/mangaki/views.py 74.00% <100.00%> (-0.29%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jilljenn jilljenn marked this pull request as ready for review October 30, 2022 00:38
@jilljenn jilljenn marked this pull request as draft October 30, 2022 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant