Xavier/flake8 #705
Open
Xavier/flake8 #705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dae735c.
jilljenn
approved these changes
Oct 31, 2020
| @@ -1,3 +1,5 @@ | |||
| from mangaki.celery import app as celery_app | |||
|
|
|||
| default_app_config = 'mangaki.apps.MangakiConfig' | |||
|
|
|||
| __all__ = ["celery_app", ] | |||
There was a problem hiding this comment.
Est-ce qu'on avait besoin de ça @RaitoBezarius ?
There was a problem hiding this comment.
Ah oui il semblerait que oui mais c'est étonnant que ce soit flake8 qui le remarque.
There was a problem hiding this comment.
flake8 remarque que une librairie a été importé sans être utilisé, ici dans un init donc j'ai regardé comment importer une librairie dynamiquement après il reste quelques infractions pour flake8 mais là ça risquerait de toucher à du code que je connais pas sans en connaitre les conséquences.
|
@RaitoBezarius Do you understand why we don't have CircleCI here? |
|
@jilljenn @RaitoBezarius https://app.circleci.com/pipelines/github/XavierDELPIERRE/mangaki j'ai mon propre circleci |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mise à la conformité vers flake8 et ajout d'un fichier de configuration .flake8 pour ignorer E501 (longueur de ligne) ,W503 (Opérateur en début de ligne)
Aucun comportement ne devrait être modifié