Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show release page when possible #667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

RaitoBezarius
Copy link
Member

No description provided.

@RaitoBezarius
Copy link
Member Author

Will fix #602.

@codecov
Copy link

codecov bot commented Oct 21, 2019

Codecov Report

Merging #667 into master will increase coverage by 0.15%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #667      +/-   ##
==========================================
+ Coverage    82.1%   82.26%   +0.15%     
==========================================
  Files          50       50              
  Lines        2314     2317       +3     
==========================================
+ Hits         1900     1906       +6     
+ Misses        414      411       -3
Impacted Files Coverage Δ
mangaki/mangaki/settings.py 77.66% <100%> (+5.12%) ⬆️
mangaki/mangaki/templatetags/version.py 80% <50%> (-8.89%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c26d6b6...844d723. Read the comment docs.

@@ -3,6 +3,7 @@
{% if mangaki_source_debug|bool %}
[debug]
DEBUG = True
SHOW_REVISION = True
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is j2 supposed to mean, in settings.ini.j2?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jinja 2, it's the template language used by Ansible.

@jilljenn
Copy link
Member

jilljenn commented Nov 1, 2019

I feel this is not likely to resolve #672.

@RaitoBezarius
Copy link
Member Author

It's not supposed to resolve it. This is a different issue.

@RaitoBezarius RaitoBezarius added this to To do in Mangaki v0.8 Nov 3, 2021
@RaitoBezarius RaitoBezarius moved this from To do to In progress in Mangaki v0.8 Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Mangaki v0.8
In progress
Development

Successfully merging this pull request may close these issues.

None yet

2 participants