-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AniList import widget #579
base: master
Are you sure you want to change the base?
Conversation
Peux-tu le faire vers un objet |
@jilljenn That might be necessary in this case. I have to think about how to translate ExternalRating to a Mangaki Rating object, still, three ways: — Personal settings, we can just ask to build a mapping from ExtRating → MangakiRating ; We can also postpone the ExtRating → MangakiRating after AniList import, this way, the import becomes a two-step process: (1) Import works & ratings in the database and stores them as ExtRating (those thoughts are based on the feedback from someone who used Mangaki & MAL and told me this was a pain for her to not be able to choose a policy and to have a Mangaki-team mapping) I suppose I can go for personal settings or predefined ones, better I can just split the process of importation into the two-step one I was explaining and take care of the policy system in another PR. |
5ab80a5
to
bab27e2
Compare
Codecov Report
@@ Coverage Diff @@
## master #579 +/- ##
=========================================
- Coverage 82.12% 77.03% -5.1%
=========================================
Files 50 83 +33
Lines 2311 4171 +1860
=========================================
+ Hits 1898 3213 +1315
- Misses 413 958 +545
Continue to review full report at Codecov.
|
Do I need a AniList account to try this PR? I guess I do, but please tell me 😄 |
- Fix related works construction ; - Turn AniList into a true singleton class ; - Rate limit signalling ;
…nsertion wrappers
ExtRatings/Ratings Phase 2 will be choices mapping from "Import Source" to Mangaki set of labels.
e6b749c
to
4177baf
Compare
Sorry, I think I broke your layout and renamed your migrations 😛 Will check this more. |
Senpai broke my code: The Animation |
No description provided.