Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AniList import widget #579

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

AniList import widget #579

wants to merge 17 commits into from

Conversation

RaitoBezarius
Copy link
Member

No description provided.

@jilljenn
Copy link
Member

jilljenn commented Aug 6, 2018

Peux-tu le faire vers un objet ExternalRating ?

@RaitoBezarius
Copy link
Member Author

@jilljenn That might be necessary in this case. I have to think about how to translate ExternalRating to a Mangaki Rating object, still, three ways:

— Personal settings, we can just ask to build a mapping from ExtRating → MangakiRating ;
— Predefined settings, we can just give something in-between customization and default ones, three maps: extreme (minimize favorite works), medium (a good amount of favorite works), gentle (most of liked works are favorite also), something along those lines. People tend to be harsh (or not) towards their own ratings and they want to establish some kind of notion of masterpiece < excellent work < good work < … ;
— Default / sane setting for everyone.

We can also postpone the ExtRating → MangakiRating after AniList import, this way, the import becomes a two-step process:

(1) Import works & ratings in the database and stores them as ExtRating
(2) Choose a policy to convert your ExtRating into Mangaki Ratings.

(those thoughts are based on the feedback from someone who used Mangaki & MAL and told me this was a pain for her to not be able to choose a policy and to have a Mangaki-team mapping)

I suppose I can go for personal settings or predefined ones, better I can just split the process of importation into the two-step one I was explaining and take care of the policy system in another PR.
This will make this one faster. Also, there will be inevitably some frontend modification (maybe creating a new tab "Imports" and some kind of onboarding mechanism for policy choices.).

@RaitoBezarius RaitoBezarius force-pushed the raito/anilist-import branch 2 times, most recently from 5ab80a5 to bab27e2 Compare August 7, 2018 12:19
@codecov
Copy link

codecov bot commented Aug 9, 2018

Codecov Report

Merging #579 into master will decrease coverage by 5.09%.
The diff coverage is 53.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #579     +/-   ##
=========================================
- Coverage   82.12%   77.03%   -5.1%     
=========================================
  Files          50       83     +33     
  Lines        2311     4171   +1860     
=========================================
+ Hits         1898     3213   +1315     
- Misses        413      958    +545
Impacted Files Coverage Δ
mangaki/mangaki/api/urls.py 100% <100%> (ø) ⬆️
mangaki/mangaki/settings.py 73.07% <100%> (+0.52%) ⬆️
mangaki/mangaki/choices.py 100% <100%> (ø) ⬆️
mangaki/mangaki/api/importation/base.py 100% <100%> (ø)
mangaki/mangaki/api/mal.py 66.66% <20%> (-3.71%) ⬇️
mangaki/mangaki/wrappers/anilist.py 77.48% <35.71%> (-9.52%) ⬇️
mangaki/mangaki/api/importation/anilist.py 58.33% <58.33%> (ø)
...gaki/mangaki/api/importation/ext_rating_convert.py 68.42% <68.42%> (ø)
mangaki/mangaki/utils/ext_ratings_mapper.py 71.87% <71.87%> (ø)
mangaki/mangaki/utils/mal.py 86.61% <77.77%> (+0.05%) ⬆️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4a2576...4177baf. Read the comment docs.

@RaitoBezarius RaitoBezarius changed the title AniList import widget WIP: AniList import widget Aug 11, 2018
@RaitoBezarius RaitoBezarius changed the title WIP: AniList import widget AniList import widget Aug 11, 2018
@jilljenn
Copy link
Member

Do I need a AniList account to try this PR? I guess I do, but please tell me 😄

@jilljenn
Copy link
Member

jilljenn commented Oct 11, 2018

Sorry, I think I broke your layout and renamed your migrations 😛 Will check this more.

@jilljenn jilljenn self-requested a review October 11, 2018 08:53
@RaitoBezarius
Copy link
Member Author

RaitoBezarius commented Oct 21, 2019

Senpai broke my code: The Animation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants