idb2pat: incorporate fixes from @HongThatCong #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williballenthin
commented
Sep 21, 2020
| if ea > func.start_ea: # skip first byte | ||
| name = idc.get_name(ea) | ||
| if name != "" and idaapi.is_uname(name): | ||
| logger.debug(str("ea 0x%X has a name %s" % (ea, name))) |
There was a problem hiding this comment.
first parameter to a log method is a format string, so we can do this instead:
logger.debug("ea 0x%X has a name %s", ea, name)
williballenthin
commented
Sep 21, 2020
| f.write("---") | ||
| if os.path.exists(filename): | ||
| with open(filename, "rb") as f: | ||
| old_sigs = f.readlines() |
There was a problem hiding this comment.
probably need to decode the bytes into a string, like:
old_sigs = f.read().decode("utf-8").split("\n")
williballenthin
commented
Sep 21, 2020
| f.write("\r\n") | ||
| f.write("---") |
There was a problem hiding this comment.
should be writing bytes, not str, since the file is open in binary mode.
williballenthin
commented
Sep 21, 2020
| sigs.append(sig) | ||
|
|
||
| for sig in sigs: | ||
| f.write(sig) |
There was a problem hiding this comment.
sig.encode("utf-8")
|
need to test this on py3, since i think there's some issues around str/bytes handling. |
|
Hi ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is the updated script that @HongThatCong referenced in #97